DevTools: Fix highlight updates Canvas side problem #18973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a52c851:
|
marvinhagemeister
approved these changes
May 21, 2020
|
Thanks for digging in and helping uncover the underlying cause! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were setting the width/height of the canvas to the screen's available width and height, but the CSS size to the viewport size. This former is generally smaller than the latter, and on some websites (e.g. everycode.store) this caused the drawn dimensions to be compressed and look bad.
The reason this behavior was particularly broken for the site above is because of a CSS rule:
So to be fair, an alternate fix would be to override this rule with our inline style.
Resolves #17432